Updated directory structure for scripted automation

5iver · July 15, 2020, 6:50am

I’ve submitted an issue for OH 3.0 to rename the $OPENHAB_CONF/automation/jsr223/ directory and I am wondering if anyone from the community has some input. This will also be the first step in removing references to JSR 223.

github.com/openhab/openhab-distro

[RFC] Add automation directory

opened 06:19AM - 15 Jul 20 UTC

5iver

For scripted automation, the scripts are loaded from $OPENHAB_CONF/automation/js…r223/... https://github.com/openhab/openhab-core/blob/master/bundles/org.openhab.core.automation.module.script.rulesupport/src/main/java/org/openhab/core/automation/module/script/rulesupport/internal/loader/ScriptFileWatcher.java#L62 Currently, users are required to manually create these directories. To make scripted automation more accessible, this directory should be included within the distribution. However, I think it would be more descriptive to use the following directories... ``` └── $OPENHAB_CONF └── automation ├── libraries └── scripts ``` I am ready to submit PRs to add these directories and to update ScriptFileWatcher, but I will wait for feedback from the @openhab/core-maintainers and @openhab/distro-maintainers.

juelicher · July 15, 2020, 7:23pm

I like removing the „jsr223“ level!

Maybe automation could be renamed to some more specific term, as all of openhab is about automation. As I prefer short names, when readability is not
at risk, I would prefer „lib“ instead of libraries, as it is shorter and the default name for such directories on Linux (and probably on all Unix systems).

If I remember correctly, there will be no DSL rules in openHAB 3, so I am wondering, if the „rules“ directory will still be needed or if „automation“ could and should be renamed to „rules“.