Upgrading and bindings in addons folder

martinvw · June 21, 2017, 6:51pm

I just upgraded (see docker upgrade steps) my openhab to the latest snapshot available via docker and it runs more or less okay as far as I can see but it refuses to reload all my bindings which I had in my addons folder, when I touch them i get this error:

20:42:24.071 [ERROR] [org.apache.felix.fileinstall        ] - Failed to install artifact: /openhab/addons/org.openhab.binding.dsmr-2.1.0-SNAPSHOT.jar
org.osgi.framework.BundleException: A bundle is already installed with the name "org.openhab.binding.dsmr" and version "2.1.0.201702282118" at location: file:/openhab/addons/org.openhab.binding.dsmr-2.1.0-SNAPSHOT.jar
        at org.eclipse.osgi.storage.Storage.install(Storage.java:496)[org.eclipse.osgi-3.10.101.v20150820-1432.jar:]
        at org.eclipse.osgi.internal.framework.BundleContextImpl.installBundle(BundleContextImpl.java:146)[org.eclipse.osgi-3.10.101.v20150820-1432.jar:]
        at org.apache.felix.fileinstall.internal.DirectoryWatcher.installOrUpdateBundle(DirectoryWatcher.java:1036)[4:org.apache.felix.fileinstall:3.5.6]
        at org.apache.felix.fileinstall.internal.DirectoryWatcher.install(DirectoryWatcher.java:952)[4:org.apache.felix.fileinstall:3.5.6]
        at org.apache.felix.fileinstall.internal.DirectoryWatcher.install(DirectoryWatcher.java:871)[4:org.apache.felix.fileinstall:3.5.6]
        at org.apache.felix.fileinstall.internal.DirectoryWatcher.doProcess(DirectoryWatcher.java:485)[4:org.apache.felix.fileinstall:3.5.6]
        at org.apache.felix.fileinstall.internal.DirectoryWatcher.process(DirectoryWatcher.java:361)[4:org.apache.felix.fileinstall:3.5.6]
        at org.apache.felix.fileinstall.internal.DirectoryWatcher.run(DirectoryWatcher.java:312)[4:org.apache.felix.fileinstall:3.5.6]

When looking in the bundle:list they show in some in between state:

START LEVEL 100 , List Threshold: 50
 ID | State     | Lvl | Version                | Name
-------------------------------------------------------------------------------------------------------
  9 | Installed |  80 | 2.1.0.201705010628     | UniFi Binding
 10 | Installed |  80 | 2.1.0.201706020845     | Rfxcom Binding
 11 | Installed |  80 | 2.1.0.201706101937     | Samsung Tv Binding
 12 | Installed |  80 | 2.1.0.201702282118     | DSMR Binding
 13 | Installed |  80 | 0.9.0.201706042133     | Eclipse SmartHome Simple Math Transformation Service

Maybe related to Adding a .jar into addons folder not working anymore?

Forcing them to uninstall and touch-ing again solved it:

bundle:uninstall 9
bundle:uninstall 10
bundle:uninstall 11
bundle:uninstall 12
bundle:uninstall 13

I hope this might help someone else

edit: add a link how I performed the upgrade

Mike_Bagdanoff · June 22, 2017, 4:17am

I noticed this too, ESH seems to load .jars from the addons folder first whenever the cache is reset. I’ve just deleted the .jars I have there, did the upgrade and then dropped them back in once OpenHAB has initialized.

If I get time at a computer soon I’ll raise an issue on github

Kai · June 22, 2017, 5:14am

On any upgrade, the tmp and cache folders need to be cleaned. Then the runtime won’t have any info about the old versions anymore and the ones from the addons folder will be used.

martinvw · June 22, 2017, 5:55am

Do you also the docker image or did you experience this with another installer?

martinvw · June 22, 2017, 6:03am

Yes I did, I updated the opening post to reflect this, I followed the openHAB docker manual for this:

http://docs.openhab.org/installation/docker.html#updating-the-image

Kai · June 22, 2017, 7:27am

Ok, then this exception does not make any sense to me
Could you try the following please: Change userdata/etc/org.apache.felix.fileinstall-deploy.cfg to have

felix.fileinstall.start.level   = 100
felix.fileinstall.active.level  = 100

(instead of 80).
Do the upgrade process again and see if it makes any difference.

Mike_Bagdanoff · June 22, 2017, 1:40pm

I install using apt-get but this also happened when I reset the cache and tmp folders.

martinvw · June 22, 2017, 9:01pm

This time (with the changes suggested by @Kai ) it did not fail, I’ll try reverting the change tomorrow and trying again.

martinvw · June 23, 2017, 1:17pm

When reverting the change (back to 80) it stills works…

Kai · June 23, 2017, 1:25pm

Reverting and upgrading again or just reverting with leaving the rest untouched?

martinvw · June 23, 2017, 1:50pm

Reverting and upgrading again

Kai · June 23, 2017, 1:51pm

Then it is now up to you to figure out what is the difference to before

martinvw · June 23, 2017, 1:58pm

I’ll keep upgrading daily

martinvw · June 24, 2017, 7:08am

I think it’s a combination of bad luck and that order, I have the problem again. I’ll change to 100 and try again.

edit: And with 100 it works

If I have more time anywhere this weekend I will try to repeat it like 5+ times, but I also have some visitors over this weekend so it might be hard to find the time…

Mike_Bagdanoff · June 24, 2017, 4:41pm

I did that this morning and my bundle:list still looks like this:

  9 | Installed | 100 | 2.1.0.201706182030     | ZWave Binding
 10 | Installed | 100 | 2.0.0.201612122156     | Animated Climacons Iconset
 11 | Active    |  80 | 5.3.1.201602281253     | OSGi JAX-RS Connector
 12 | Active    |  80 | 2.3.1                  | Gson
 13 | Active    |  80 | 18.0.0                 | Guava: Google Core Libraries for Java

and doing a stop/start on bundle 9 (zwave) gives me this:

Error executing command: Error executing command on bundles:
        Error starting bundle 9: Could not resolve module: org.openhab.binding.zwave [9]
  Unresolved requirement: Import-Package: com.google.common.collect

I fixed it like this:

Deleted the .jar files
bundle:uninstall 9
bundle:uninstall 10
stopped the openhab2 service
dropped the .jars back in
started the openhab2 service
re-added the serial transport bundle because I always forget that
all seems to work now


221 | Active   |  80 | 1.5.8.v20160511-1038   | swagger-jersey2-jaxrs (wrap)
222 | Active   | 100 | 2.1.0.201706182030     | ZWave Binding
223 | Active   | 100 | 2.0.0.201612122156     | Animated Climacons Iconset

Kai · June 24, 2017, 6:14pm

Ok, so my idea does not seem to help. Sorry, I am out of ideas on how this happens - would need to invest more time to investigate…

Off-topic: What is this iconset that you are using there?

hakan · June 24, 2017, 8:51pm

Should be the animated icons from this thread:

martinvw · June 25, 2017, 6:20am

Thats it!

I also have some bindings depending on the serial transport bundle, but I also have some other bindings installed via the normal path which require the serial transport bundle, so that is why it worked for me to change this

So it crashed/failed while installing from the addons folder because there was an error and in my case it was automatically resolved if we did it at the end because then the serial-transport was was present.

Mike_Bagdanoff · June 25, 2017, 11:41pm

That is it, though it doesn’t seem to work anymore since I upgraded. No errors aside from the 404 that is returned by the icon path now.
edit: bah… the super important breaking change from i18nProvider to TranslationProvider strikes again.

Maybe, my errors persisted after installing the serial bundle until I removed and reinstalled the zwave .jar. Then the “Unresolved requirement: Import-Package: com.google.common.collect” error stopped.

martinvw · June 26, 2017, 6:41am

What do you mean? Is there already an issue for this?