WARNINGs and ERRORs on mvn build syntax validation


(Markus Michels) #1

When I’m running a “mvn clean install” or “mvn install” for my bindig I get the following WARNINGs:

[ERROR] Code Analysis Tool has found: 
 5 error(s)! 
 6 warning(s) 
 32 info(s)
[WARNING] .binding.entertaintv/ESH-INF/binding/binding.xml:[3]
There were whitespace characters used for indentation. Please use tab characters instead
[WARNING] .binding.entertaintv/ESH-INF/thing/thing-types.xml:[6]
There were whitespace characters used for indentation. Please use tab characters instead

I checked the Eclipse Editor options and it says: Using tabs for identation
However, if I press tab and backspace I see that Eclipse inserts spaces instead - how to fix this?

Even more strange:

[ERROR] .binding.entertaintv/META-INF/MANIFEST.MF:[0]
The package  should be marked as "internal" if it is not exported.
[ERROR] .binding.entertaintv/META-INF/MANIFEST.MF:[0]
The package org should be marked as "internal" if it is not exported.
[ERROR] .binding.entertaintv/META-INF/MANIFEST.MF:[0]
The package org.openhab should be marked as "internal" if it is not exported.
[ERROR] .binding.entertaintv/META-INF/MANIFEST.MF:[0]
The package org.openhab.binding should be marked as "internal" if it is not exported.
[ERROR] .binding.entertaintv/META-INF/MANIFEST.MF:[0]
The package org.openhab.binding.entertaintv should be marked as "internal" if it is not exported.

I have no klue where it gets the information that the package is exported even it names “”, “org”, “org.openhab”, “org.openhab.binding”, “org.openhab.binding.entertaintv”

That’s my structure in Eclipse:

That’s the MANIFEST.MF

Manifest-Version: 1.0
Bundle-ActivationPolicy: lazy
Bundle-ClassPath: 
 .,
 lib/javax.json-api-1.1.3.jar,
 lib/javax.json-1.1.3.jar
Bundle-ManifestVersion: 2
Bundle-Name: EntertainTV Binding
Bundle-RequiredExecutionEnvironment: JavaSE-1.8
Bundle-SymbolicName: org.openhab.binding.entertaintv;singleton:=true
Automatic-Module-Name: org.openhab.binding.entertaintv
Bundle-Vendor: openHAB
Bundle-Version: 2.4.0.qualifier
Import-Package: 
 javax.servlet,
 javax.servlet.http,
 org.apache.commons.lang,
 org.apache.commons.net,
 org.apache.commons.net.util,
 org.eclipse.jdt.annotation;resolution:=optional,
 org.eclipse.smarthome.config.core,
 org.eclipse.smarthome.config.discovery,
 org.eclipse.smarthome.config.discovery.upnp,
 org.eclipse.smarthome.core.library.types,
 org.eclipse.smarthome.core.thing,
 org.eclipse.smarthome.core.thing.binding,
 org.eclipse.smarthome.core.thing.binding.builder,
 org.eclipse.smarthome.core.thing.type,
 org.eclipse.smarthome.core.types,
 org.eclipse.smarthome.io.net.http,
 org.eclipse.smarthome.io.transport.upnp,
 org.jupnp.model.meta,
 org.jupnp.model.types,
 org.osgi.framework,
 org.osgi.service.cm,
 org.osgi.service.component,
 org.osgi.service.component.annotations;resolution:=optional,
 org.osgi.service.http,
 org.slf4j
Service-Component: OSGI-INF/*.xml

A “mvn -DskipChecks=true install” completes and creates a jar in target.

How to get rid of those annoying errors?


(namraccr) #2
Simple. Fix the identified whitespace problems.

This reply was pasted into the wrong window.


(namraccr) #3

I believe the errors are trying to say that the named packages should be either exported or marked as internal.


(Wouter Born) #4

You can fix the errors:

should be marked as "internal" if it is not exported

by removing all .DS_Store files from your source code directories.


(Markus Michels) #5

there are no .DS_Store files (including hidden files)


(Wouter Born) #6

If they are not there… then what is this?

DS_Store


(Markus Michels) #7

entertaintv binding was replaced by telekomtv