OH3 Astro Rule isnt executed

Setup, Configuration and Use Scripts & Rules
2

It’s OH2 code, where now is a Joda datetime object.
In OH3, now is a ZonedDateTime, with different methods.
Your openhab.log should be telling you something along these lines.

Clues here I think -

and