openHAB 3.3 Release discussion

Lolodomo · June 29, 2022, 7:02am

I don’t thing ther’e was any change to GoogleTTS between M7 and final release.
Could you check that the problem is not in your (Python) rule engine ?
Just try the say command in the console to see if GoogleTTS is working or not.

Mikel_2 · June 29, 2022, 7:22am

It was not me.

In version openHABian 3.2. (it was a totally new installation) everything was fine, then I did the Upgrade to 3.3 and these 3 devices have been disabled, by … the Upgrade (?)

In the MainUI, i wasnt able to set the parameter correctly (only on/off = 0 and 1 i guess), was manually only possible in the Yaml section.

After the first manual correction … now the configuration sets correct the parameters (true/false) in the yaml section. Strange but it works

timl · June 29, 2022, 8:33am

Hmmm… perhaps I have the same issue, because there are some “Init” rules, that are not executed anymore, if the openhab is restarted. Where I could find information about log files of openhab/openhabian? /var/log/openhab/openhab.log do not show any information about startlevel?!

UPDATE: Perhaps I found the problem in this log. There are Netatmo-Things that are invalid (I could not delete them via GUI: State changed to REMOVING, but nothing happens. How can I drop this 3 Things) and there are some errors in Blockly rules (I will check this later).

Dominik_Bernhardt · June 29, 2022, 9:15am

If you click again on delete the thing can be forefully deleted

rubens · June 29, 2022, 9:26am


openhab> voice ttsservices                                                                                                                                                                          
* Google Cloud (googletts)

openhab> voice voices
  Google Cloud - Afrikaans (South Africa) - af-ZA-Standard-A (googletts:afZAStandardA)
  Google Cloud - Arabic (XA) - ar-XA-Standard-A (googletts:arXAStandardA)
   ..
  Google Cloud - Vietnamese (Vietnam) - vi-VN-Wavenet-D (googletts:viVNWavenetD)

openhab> voice say test
An unexpected error occurred during execution.

and in the log I get:


2022-06-29 11:06:06.404 [DEBUG] [.googletts.internal.GoogleTTSService] - Synthesize 'test ' for voice 'googletts:deDEWavenetC' in format AudioFormat [codec=PCM_SIGNED, container=WAVE, bigEndian=true, bitDepth=16, bitRate=705600, frequency=44100channels=1]
2022-06-29 11:06:06.411 [DEBUG] [lient.internal.OAuthStoreHandlerImpl] - Decrypting token: AccessTokenResponse [accessToken=LdEWmHAg7GjsYW8XBtoBIWPo7Y1oW3lX4tWVbxkZUw4yzxsrVPhAm2YJHEyB3vvO9mK3h6RJ26OCCfGz5lhZ6j4nmHIyiRkv/GNKdeK7yey85xsMRaPfK6Fd48a+5rQh17Iamybo1ZvC8Xlb5YAfCrmCN0Mx/Ziu1D7cMLKl8iKqvlXa5x3PL8TtQyrCILUWG/AebJ7WmWETjwDJ0Gt1+Zj73By8G4O6PEOHQ+hZfiMlA8l3CCayCNvABy0RqxQP, tokenType=Bearer, expiresIn=3461, refreshToken=null, scope=https://www.googleapis.com/auth/cloud-platform, state=null, createdOn=2022-06-28T17:53:33.196313]
2022-06-29 11:06:06.612 [ERROR] [b.core.io.console.ConsoleInterpreter] - An error occurred while executing the console command.
java.lang.NullPointerException: null
	at org.openhab.voice.googletts.internal.GoogleCloudAPI.synthesizeSpeechByGoogle(GoogleCloudAPI.java:456) ~[?:?]
	at org.openhab.voice.googletts.internal.GoogleCloudAPI.synthesizeSpeech(GoogleCloudAPI.java:356) ~[?:?]
	at org.openhab.voice.googletts.internal.GoogleTTSService.synthesize(GoogleTTSService.java:335) ~[?:?]
	at org.openhab.core.voice.internal.VoiceManagerImpl.say(VoiceManagerImpl.java:241) ~[?:?]
	at org.openhab.core.voice.internal.VoiceManagerImpl.say(VoiceManagerImpl.java:176) ~[?:?]
	at org.openhab.core.voice.internal.VoiceConsoleCommandExtension.say(VoiceConsoleCommandExtension.java:246) ~[?:?]
	at org.openhab.core.voice.internal.VoiceConsoleCommandExtension.execute(VoiceConsoleCommandExtension.java:112) ~[?:?]
	at org.openhab.core.io.console.ConsoleInterpreter.execute(ConsoleInterpreter.java:57) [bundleFile:?]
	at org.openhab.core.io.console.karaf.internal.CommandWrapper.execute(CommandWrapper.java:77) [bundleFile:?]
	at org.apache.karaf.shell.impl.console.osgi.secured.SecuredCommand.execute(SecuredCommand.java:68) [bundleFile:4.3.7]
	at org.apache.karaf.shell.impl.console.osgi.secured.SecuredCommand.execute(SecuredCommand.java:86) [bundleFile:4.3.7]
	at org.apache.felix.gogo.runtime.Closure.executeCmd(Closure.java:599) [bundleFile:4.3.7]
	at org.apache.felix.gogo.runtime.Closure.executeStatement(Closure.java:526) [bundleFile:4.3.7]
	at org.apache.felix.gogo.runtime.Closure.execute(Closure.java:415) [bundleFile:4.3.7]
	at org.apache.felix.gogo.runtime.Pipe.doCall(Pipe.java:416) [bundleFile:4.3.7]
	at org.apache.felix.gogo.runtime.Pipe.call(Pipe.java:229) [bundleFile:4.3.7]
	at org.apache.felix.gogo.runtime.Pipe.call(Pipe.java:59) [bundleFile:4.3.7]
	at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
	at java.lang.Thread.run(Thread.java:829) [?:?]

Both org.openhab.core.auth.oauth2client and org.openhab.voice.googlettsare set to TRACE

However, I get this now with M7, too

Update:

After seeing the failure on M7 this morning I did a restart, generated a new authCode, put that in and voice say test worked again from console.
So I re-installed 3.3.0-1, starting up googletts did not work, so generated a new authCode, put that in and voice say test worked again from console.
Thus, my impression that the released version comes with completly broken googletts was wrong.
Still, the outh2 authentication appears to be super fragile and the process to renew it with copying the authCode from the address line feels clumsy, to put it mildly.

Cplant · June 29, 2022, 11:13am

I’m not 100% certain if the error which I now keep getting when opening the Apple Watch App upon launch ("Request explicitly cancelled") is related to my upgrade from 3.2 to 3.3, but if others have the same issue, feel free to contribute to the thread here.

Z0l · June 29, 2022, 11:18am

Hello, just wanted to let everyone know that my Openhab 3.2.0 → 3.3.0 upgrade (I’m using Docker) was completed without any errors, hiccups or annoyances at all. This is the first time I had nothing to do (no rule rewrites or redefining things/items) so just wanted to put a big thank you out there for the great work the developers have put into this.

On 3.2.0, I had some issues with jupnp so I had to add some additional configuration on timeouts/retries to make my Sonos speakers work; I haven’t removed that but I will check if those are still needed on 3.3.0. and report separately.

Lolodomo · June 29, 2022, 11:44am

Ok, I think I saw several topics in the forum about google stuff no more working due to changes in way to suthenticate.

The last change in this binding is dated 12th of April.

The NPE at this line is because synthesizeSpeechResponse.getAudioContent() is not tested, So at least this NPE could be avoided in favor of a more appropriate error.

github.com

openhab/openhab-addons/blob/main/bundles/org.openhab.voice.googletts/src/main/java/org/openhab/voice/googletts/internal/GoogleCloudAPI.java#L456


      
          /**
           * Copyright (c) 2010-2024 Contributors to the openHAB project
           *
           * See the NOTICE file(s) distributed with this work for additional
           * information.
           *
           * This program and the accompanying materials are made available under the
           * terms of the Eclipse Public License 2.0 which is available at
           * http://www.eclipse.org/legal/epl-2.0
           *
           * SPDX-License-Identifier: EPL-2.0
           */
          package org.openhab.voice.googletts.internal;
          
          import java.io.IOException;
          import java.nio.charset.StandardCharsets;
          import java.util.ArrayList;
          import java.util.Base64;
          import java.util.Dictionary;
          import java.util.HashMap;
          import java.util.HashSet;
          import java.util.List;
          import java.util.Locale;
          import java.util.Map;
          import java.util.Set;
          
          import org.eclipse.jdt.annotation.Nullable;
          import org.eclipse.jetty.http.HttpHeader;
          import org.eclipse.jetty.http.MimeTypes;
          import org.openhab.core.audio.AudioFormat;
          import org.openhab.core.auth.AuthenticationException;
          import org.openhab.core.auth.client.oauth2.AccessTokenResponse;
          import org.openhab.core.auth.client.oauth2.OAuthClientService;
          import org.openhab.core.auth.client.oauth2.OAuthException;
          import org.openhab.core.auth.client.oauth2.OAuthFactory;
          import org.openhab.core.auth.client.oauth2.OAuthResponseException;
          import org.openhab.core.i18n.CommunicationException;
          import org.openhab.core.io.net.http.HttpRequestBuilder;
          import org.openhab.voice.googletts.internal.dto.AudioConfig;
          import org.openhab.voice.googletts.internal.dto.AudioEncoding;
          import org.openhab.voice.googletts.internal.dto.ListVoicesResponse;
          import org.openhab.voice.googletts.internal.dto.SsmlVoiceGender;
          import org.openhab.voice.googletts.internal.dto.SynthesisInput;
          import org.openhab.voice.googletts.internal.dto.SynthesizeSpeechRequest;
          import org.openhab.voice.googletts.internal.dto.SynthesizeSpeechResponse;
          import org.openhab.voice.googletts.internal.dto.Voice;
          import org.openhab.voice.googletts.internal.dto.VoiceSelectionParams;
          import org.osgi.service.cm.Configuration;
          import org.osgi.service.cm.ConfigurationAdmin;
          import org.slf4j.Logger;
          import org.slf4j.LoggerFactory;
          
          import com.google.gson.Gson;
          import com.google.gson.GsonBuilder;
          import com.google.gson.JsonSyntaxException;
          
          /**
           * Google Cloud TTS API call implementation.
           *
           * @author Gabor Bicskei - Initial contribution and API
           */
          class GoogleCloudAPI {
          
              private static final String BEARER = "Bearer ";
          
              private static final String GCP_AUTH_URI = "https://accounts.google.com/o/oauth2/auth";
              private static final String GCP_TOKEN_URI = "https://accounts.google.com/o/oauth2/token";
              private static final String GCP_REDIRECT_URI = "https://www.google.com";
              /**
               * Google Cloud Platform authorization scope
               */
              private static final String GCP_SCOPE = "https://www.googleapis.com/auth/cloud-platform";
          
              /**
               * URL used for retrieving the list of available voices
               */
              private static final String LIST_VOICES_URL = "https://texttospeech.googleapis.com/v1/voices";
          
              /**
               * URL used for synthesizing text to speech
               */
              private static final String SYTNHESIZE_SPEECH_URL = "https://texttospeech.googleapis.com/v1/text:synthesize";
          
              /**
               * Logger
               */
              private final Logger logger = LoggerFactory.getLogger(GoogleCloudAPI.class);
          
              /**
               * Supported voices and locales
               */
              private final Map<Locale, Set<GoogleTTSVoice>> voices = new HashMap<>();
          
              /**
               * Configuration
               */
              private @Nullable GoogleTTSConfig config;
          
              private final Gson gson = new GsonBuilder().create();
              private final ConfigurationAdmin configAdmin;
              private final OAuthFactory oAuthFactory;
          
              private @Nullable OAuthClientService oAuthService;
          
              /**
               * Constructor.
               *
               */
              GoogleCloudAPI(ConfigurationAdmin configAdmin, OAuthFactory oAuthFactory) {
                  this.configAdmin = configAdmin;
                  this.oAuthFactory = oAuthFactory;
              }
          
              /**
               * Configuration update.
               *
               * @param config New configuration.
               */
              void setConfig(GoogleTTSConfig config) {
                  this.config = config;
          
                  if (oAuthService != null) {
                      oAuthFactory.ungetOAuthService(GoogleTTSService.SERVICE_PID);
                      oAuthService = null;
                  }
          
                  String clientId = config.clientId;
                  String clientSecret = config.clientSecret;
                  if (clientId != null && !clientId.isEmpty() && clientSecret != null && !clientSecret.isEmpty()) {
                      final OAuthClientService oAuthService = oAuthFactory.createOAuthClientService(GoogleTTSService.SERVICE_PID,
                              GCP_TOKEN_URI, GCP_AUTH_URI, clientId, clientSecret, GCP_SCOPE, false);
                      this.oAuthService = oAuthService;
                      try {
                          getAccessToken();
                          initVoices();
                      } catch (AuthenticationException | CommunicationException e) {
                          logger.warn("Error initializing Google Cloud TTS service: {}", e.getMessage());
                          oAuthFactory.ungetOAuthService(GoogleTTSService.SERVICE_PID);
                          this.oAuthService = null;
                          voices.clear();
                      }
                  } else {
                      voices.clear();
                  }
              }
          
              public void dispose() {
                  if (oAuthService != null) {
                      oAuthFactory.ungetOAuthService(GoogleTTSService.SERVICE_PID);
                      oAuthService = null;
                  }
                  voices.clear();
              }
          
              /**
               * Fetches the OAuth2 tokens from Google Cloud Platform if the auth-code is set in the configuration. If successful
               * the auth-code will be removed from the configuration.
               *
               * @throws AuthenticationException
               * @throws CommunicationException
               */
              @SuppressWarnings("null")
              private void getAccessToken() throws AuthenticationException, CommunicationException {
                  String authcode = config.authcode;
                  if (authcode != null && !authcode.isEmpty()) {
                      logger.debug("Trying to get access and refresh tokens.");
                      try {
                          AccessTokenResponse response = oAuthService.getAccessTokenResponseByAuthorizationCode(authcode,
                                  GCP_REDIRECT_URI);
                          if (response.getRefreshToken() == null || response.getRefreshToken().isEmpty()) {
                              throw new AuthenticationException("Error fetching refresh token. Please reauthorize");
                          }
                      } catch (OAuthException | OAuthResponseException e) {
                          logger.debug("Error fetching access token: {}", e.getMessage(), e);
                          throw new AuthenticationException(
                                  "Error fetching access token. Invalid authcode? Please generate a new one.");
                      } catch (IOException e) {
                          throw new CommunicationException(
                                  String.format("An unexpected IOException occurred: %s", e.getMessage()));
                      }
          
                      config.authcode = null;
          
                      try {
                          Configuration serviceConfig = configAdmin.getConfiguration(GoogleTTSService.SERVICE_PID);
                          Dictionary<String, Object> configProperties = serviceConfig.getProperties();
                          if (configProperties != null) {
                              configProperties.put(GoogleTTSService.PARAM_AUTHCODE, "");
                              serviceConfig.update(configProperties);
                          }
                      } catch (IOException e) {
                          // should not happen
                          logger.warn(
                                  "Failed to update configuration for Google Cloud TTS service. Please clear the 'authcode' configuration parameter manualy.");
                      }
                  }
              }
          
              @SuppressWarnings("null")
              private String getAuthorizationHeader() throws AuthenticationException, CommunicationException {
                  final AccessTokenResponse accessTokenResponse;
                  try {
                      accessTokenResponse = oAuthService.getAccessTokenResponse();
                  } catch (OAuthException | OAuthResponseException e) {
                      logger.debug("Error fetching access token: {}", e.getMessage(), e);
                      throw new AuthenticationException(
                              "Error fetching access token. Invalid authcode? Please generate a new one.");
                  } catch (IOException e) {
                      throw new CommunicationException(String.format("An unexpected IOException occurred: %s", e.getMessage()));
                  }
                  if (accessTokenResponse == null || accessTokenResponse.getAccessToken() == null
                          || accessTokenResponse.getAccessToken().isEmpty()) {
                      throw new AuthenticationException("No access token. Is this thing authorized?");
                  }
                  if (accessTokenResponse.getRefreshToken() == null || accessTokenResponse.getRefreshToken().isEmpty()) {
                      throw new AuthenticationException("No refresh token. Please reauthorize");
                  }
                  return BEARER + accessTokenResponse.getAccessToken();
              }
          
              /**
               * Loads supported audio formats
               *
               * @return Set of audio formats
               */
              Set<String> getSupportedAudioFormats() {
                  Set<String> formats = new HashSet<>();
                  for (AudioEncoding audioEncoding : AudioEncoding.values()) {
                      if (audioEncoding != AudioEncoding.AUDIO_ENCODING_UNSPECIFIED) {
                          formats.add(audioEncoding.toString());
                      }
                  }
                  return formats;
              }
          
              /**
               * Supported locales.
               *
               * @return Set of locales
               */
              Set<Locale> getSupportedLocales() {
                  return voices.keySet();
              }
          
              /**
               * Supported voices for locale.
               *
               * @param locale Locale
               * @return Set of voices
               */
              Set<GoogleTTSVoice> getVoicesForLocale(Locale locale) {
                  Set<GoogleTTSVoice> localeVoices = voices.get(locale);
                  return localeVoices != null ? localeVoices : Set.of();
              }
          
              /**
               * Google API call to load locales and voices.
               *
               * @throws AuthenticationException
               * @throws CommunicationException
               */
              private void initVoices() throws AuthenticationException, CommunicationException {
                  if (oAuthService != null) {
                      voices.clear();
                      for (GoogleTTSVoice voice : listVoices()) {
                          Locale locale = voice.getLocale();
                          Set<GoogleTTSVoice> localeVoices;
                          if (!voices.containsKey(locale)) {
                              localeVoices = new HashSet<>();
                              voices.put(locale, localeVoices);
                          } else {
                              localeVoices = voices.get(locale);
                          }
                          localeVoices.add(voice);
                      }
                  } else {
                      logger.error("Google client is not initialized!");
                  }
              }
          
              @SuppressWarnings("null")
              private List<GoogleTTSVoice> listVoices() throws AuthenticationException, CommunicationException {
                  HttpRequestBuilder builder = HttpRequestBuilder.getFrom(LIST_VOICES_URL)
                          .withHeader(HttpHeader.AUTHORIZATION.name(), getAuthorizationHeader());
          
                  try {
                      ListVoicesResponse listVoicesResponse = gson.fromJson(builder.getContentAsString(),
                              ListVoicesResponse.class);
          
                      if (listVoicesResponse == null || listVoicesResponse.getVoices() == null) {
                          return List.of();
                      }
          
                      List<GoogleTTSVoice> result = new ArrayList<>();
                      for (Voice voice : listVoicesResponse.getVoices()) {
                          for (String languageCode : voice.getLanguageCodes()) {
                              result.add(new GoogleTTSVoice(Locale.forLanguageTag(languageCode), voice.getName(),
                                      voice.getSsmlGender().name()));
                          }
                      }
                      return result;
                  } catch (JsonSyntaxException e) {
                      // do nothing
                  } catch (IOException e) {
                      throw new CommunicationException(String.format("An unexpected IOException occurred: %s", e.getMessage()));
                  }
                  return List.of();
              }
          
              /**
               * Converts audio format to Google parameters.
               *
               * @param codec Requested codec
               * @return String array of Google audio format and the file extension to use.
               */
              private String getFormatForCodec(String codec) {
                  switch (codec) {
                      case AudioFormat.CODEC_MP3:
                          return AudioEncoding.MP3.toString();
                      case AudioFormat.CODEC_PCM_SIGNED:
                          return AudioEncoding.LINEAR16.toString();
                      default:
                          throw new IllegalArgumentException("Audio format " + codec + " is not yet supported");
                  }
              }
          
              public byte[] synthesizeSpeech(String text, GoogleTTSVoice voice, String codec) {
                  String format = getFormatForCodec(codec);
                  try {
                      return synthesizeSpeechByGoogle(text, voice, format);
                  } catch (AuthenticationException e) {
                      logger.warn("Error authenticating Google Cloud TTS service: {}", e.getMessage());
                      if (oAuthService != null) {
                          oAuthFactory.ungetOAuthService(GoogleTTSService.SERVICE_PID);
                          oAuthService = null;
                      }
                  } catch (CommunicationException e) {
                      logger.warn("Error initializing Google Cloud TTS service: {}", e.getMessage());
                  }
                  voices.clear();
                  return null;
              }
          
              /**
               * Call Google service to synthesize the required text
               *
               * @param text Text to synthesize
               * @param voice Voice parameter
               * @param audioFormat Audio encoding format
               * @return Audio input stream or {@code null} when encoding exceptions occur
               * @throws AuthenticationException
               * @throws CommunicationException
               */
              @SuppressWarnings("null")
              private byte[] synthesizeSpeechByGoogle(String text, GoogleTTSVoice voice, String audioFormat)
                      throws AuthenticationException, CommunicationException {
                  AudioConfig audioConfig = new AudioConfig(AudioEncoding.valueOf(audioFormat), config.pitch, config.speakingRate,
                          config.volumeGainDb);
                  SynthesisInput synthesisInput = new SynthesisInput(text);
                  VoiceSelectionParams voiceSelectionParams = new VoiceSelectionParams(voice.getLocale().getLanguage(),
                          voice.getLabel(), SsmlVoiceGender.valueOf(voice.getSsmlGender()));
          
                  SynthesizeSpeechRequest request = new SynthesizeSpeechRequest(audioConfig, synthesisInput,
                          voiceSelectionParams);
          
                  HttpRequestBuilder builder = HttpRequestBuilder.postTo(SYTNHESIZE_SPEECH_URL)
                          .withHeader(HttpHeader.AUTHORIZATION.name(), getAuthorizationHeader())
                          .withContent(gson.toJson(request), MimeTypes.Type.APPLICATION_JSON.name());
          
                  try {
                      SynthesizeSpeechResponse synthesizeSpeechResponse = gson.fromJson(builder.getContentAsString(),
                              SynthesizeSpeechResponse.class);
          
                      if (synthesizeSpeechResponse == null) {
                          return null;
                      }
          
                      byte[] encodedBytes = synthesizeSpeechResponse.getAudioContent().getBytes(StandardCharsets.UTF_8);
                      return Base64.getDecoder().decode(encodedBytes);
                  } catch (JsonSyntaxException e) {
                      // do nothing
                  } catch (IOException e) {
                      throw new CommunicationException(String.format("An unexpected IOException occurred: %s", e.getMessage()));
                  }
                  return null;
              }
          
              boolean isInitialized() {
                  return oAuthService != null;
              }
          }

This file has been truncated. show original

rubens · June 29, 2022, 12:15pm

Thanks for looking into it.

Yes, this was in M7 already. I figured how to get it with google but it’s clumsy (copy authCode from addressline of browser, edit the code 4%2F → 4/ ) and authentication seems fragile so I’m forced to repeat that quite often.
Frankly, that part doesn’t feel Ready.

I posted an update to my former post: in a nutshell I see now that M7 and 3.3.0-1 behave quite alike.

fnu · June 29, 2022, 12:16pm

Hi there,

updated my openhabian using “openhabian-config”. Installation was quite fresh, I did start over 2 month ago from a newly written microSD card, just restoring my files from /etc/openhab/*

I stopped openhabian services before requesting update, cleaned cache, then reboot. Now I can’t see my things in PaperUI and just see continously that message in log viewer:

2022-06-29 14:06:30.012 [INFO ] [core.karaf.internal.FeatureInstaller] - Some .kar files are not installed yet. Delaying add-on installation by 15s.

2022-06-29 14:06:45.016 [INFO ] [core.karaf.internal.FeatureInstaller] - Some .kar files are not installed yet. Delaying add-on installation by 15s.

2022-06-29 14:07:00.019 [INFO ] [core.karaf.internal.FeatureInstaller] - Some .kar files are not installed yet. Delaying add-on installation by 15s.

2022-06-29 14:07:15.023 [INFO ] [core.karaf.internal.FeatureInstaller] - Some .kar files are not installed yet. Delaying add-on installation by 15s.

2022-06-29 14:07:30.027 [INFO ] [core.karaf.internal.FeatureInstaller] - Some .kar files are not installed yet. Delaying add-on installation by 15s.

2022-06-29 14:07:45.030 [INFO ] [core.karaf.internal.FeatureInstaller] - Some .kar files are not installed yet. Delaying add-on installation by 15s.

2022-06-29 14:08:00.034 [INFO ] [core.karaf.internal.FeatureInstaller] - Some .kar files are not installed yet. Delaying add-on installation by 15s.

2022-06-29 14:08:15.037 [INFO ] [core.karaf.internal.FeatureInstaller] - Some .kar files are not installed yet. Delaying add-on installation by 15s.

2022-06-29 14:08:30.041 [INFO ] [core.karaf.internal.FeatureInstaller] - Some .kar files are not installed yet. Delaying add-on installation by 15s.

fnu · June 29, 2022, 12:30pm

Ok, strange, another graceful restart did solve that issue, stop openhab.service, clean cache, reboot …

mhilbush · June 29, 2022, 12:49pm

Not sure of it’s relevant here, but I ran into an issue with reauthorizations after the first auth is a problem because the refresh token is returned only after the first authorization. The net effect is that it works until the access token needs to be refreshed (about an hour), then it breaks.

I pushed this change for the nest binding, but may be relevant for Google TTS, too. Note the addition of &prompt=consent to the URL.

github.com/openhab/openhab-addons

[nest] Fix for missing refresh token after reauthorization

openhab:main ← mhilbush:nest-refresh-token

opened 02:30PM - 10 May 22 UTC

mhilbush

+15 -5

By default, the Google OAuth API returns the refresh token only on the first aut…horization. On subsequent authorizations using the same Client ID and Secret, Google does not return the refresh token in the access token response. This causes the binding to fail on the first refresh of the access token after a reauthorization. This affects the SDM and Pub/Sub APIs. However, the failure is more spectacular with the Pub/Sub API as it causes the binding to repeatedly do a pub/sub request against the Google API every 20-40 msec. This PR adds a new query parameter (prompt=consent) to the URL used to get the authorization code. This parameter causes Google to always return the refresh token in the authorization response (via `oAuthService.getAccessTokenResponseByAuthorizationCode`). In addition, this PR adds checks to make sure the refresh token in present in the access token response in order to fail more quickly and gracefully if the refresh token is missing. Further details of my analysis are here. https://community.openhab.org/t/nest-binding-throwing-pub-sub-errors-repeatedly/135721 I know @wborn is pretty time-constrained right now, but I'm hopeful he can find a few minutes to review. 😉 Signed-off-by: Mark Hilbush <mark@hilbush.com>

Edit: I should note that this problem drove me absolutely crazy for days. I would do a reauth, then it would work for a while, then it would break. Rinse and repeat. Finally figured it out.

rubens · June 29, 2022, 1:25pm

Thanks! Looks like it might be relevant indeed.
There is a line with the values of the decrypted token in the log and I had noticed it always showed refreshToken=null,
Using the &prompt=consent parameter in the uri when requesting the authCode results in a token which does have a value there.

Let’s see if this results in a more stable behavior.

mhilbush · June 29, 2022, 1:36pm

Yep, a null refresh token in the log is a definite indicator of the problem.

If that’s it, we’ll need an update to the Readme to include the change to the authorization url.

And maybe a change to the code to complain if the refresh token is null.

Lolodomo · June 29, 2022, 3:06pm

There was an issue but it is now closed. Don’t know if expected.

github.com/openhab/openhab-addons

Google add-ons use deprecated OAuth out-of-band (flow)

opened 11:37AM - 10 Mar 22 UTC

closed 08:39PM - 12 Apr 22 UTC

wborn

bug

Some add-ons using Google APIs still use the deprecated OOB flow. It is no longe…r possible to create new Google OAuth tokens using the OOB flow since February 28th. See: https://developers.googleblog.com/2022/02/making-oauth-flows-safer.html#disallowed-oob As a result it is no longer possible to setup the following add-ons: * Google Cloud Text-to-Speech * Google Cloud Speech-To-Text * Nest Binding These need to be changed to use one of the other flows.

openhabgs · June 29, 2022, 3:22pm

All,
regarding the ZWAVE problem resulting in this error message: “zwave HANDLER_CONFIGURATION_PENDING”, I found an easy way to fix it in the UI.
I had this (german) error message:

then I went in to the “code” section of the thing where I changed the entry from the error message:

and - voila - the thing is online again.

And for further bugfixing, these are the log messages:

2> 022-06-29 17:37:03.839 [WARN ] [.core.thing.binding.BaseThingHandler] - Attempt to apply invalid configuration ‘Configuration[{key=config_10_1; type=BigDecimal; value=10}, {key=wakeup_interval; type=BigDecimal; value=3600}, {key=group_1; type=ArrayList; value=[controller]}, {key=binding_pollperiod; type=BigDecimal; value=3600}, {key=group_2; type=ArrayList; value=[controller]}, {key=config_111_2; type=BigDecimal; value=10}, {key=config_112_1; type=BigDecimal; value=5}, {key=config_100_1; type=BigDecimal; value=1}, {key=config_110_1; type=BigDecimal; value=0}, {key=config_101_4; type=BigDecimal; value=7200}, {key=wakeup_node; type=BigDecimal; value=1}, {key=config_102_4; type=BigDecimal; value=0}, {key=config_113_2; type=BigDecimal; value=150}, {key=config_114_1; type=BigDecimal; value=10}, {key=config_12_1; type=BigDecimal; value=10}, {key=config_103_4; type=BigDecimal; value=300}, {key=config_13_2; type=BigDecimal; value=5}, {key=config_14_1; type=BigDecimal; value=0}, {key=config_104_4; type=BigDecimal; value=86400}, {key=config_15_1; type=BigDecimal; value=1}, {key=node_id; type=BigDecimal; value=6}]’ on thing ‘zwave:device:Z-Wave-Controller:node6’ blocked. This is most likely a bug: {config_101_4=The value 7200 does not match allowed parameter options. Allowed options are: [ParameterOption [value=“0”, label=“Disabled”]], config_12_1=The value 10 does not match allowed parameter options. Allowed options are: [ParameterOption [value=“0”, label=“Disabled”]], config_104_4=The value 86400 does not match allowed parameter options. Allowed options are: [ParameterOption [value=“0”, label=“Disabled”]]}

ysc · June 29, 2022, 5:07pm

The API Explorer doesn’t support SSE endpoints.

This is the state update SSE endpoint, not the general events SSE which is /rest/events.

For the record, here’s how the state update SSE endpoint works: when you receive that initial ready event, you have to do a HTTP POST to /rest/events/states/{connectionId} with {connectionId} being the GUID that you receive as data for the ready event. In that POST request (this one you can perform with the API Explorer) you also have to specify an array of item names you’re interested in. Then you will begin to see events appearing on the /rest/events/states response when the specified items’ states get updated.

OMR · June 29, 2022, 9:52pm

Just updated from 3.3.0M8 to 3.3.0 and had to manually start a bunch of bundles in karaf that were stuck in Resolved and not Active …
Besides from that, things looks OK. (10min after)

J-N-K · June 29, 2022, 9:58pm

Did you try a second start before manually starting the bundles? I have sometimes seen a similar issue in the past, but only on first starts, never on second or later.

OMR · June 29, 2022, 10:13pm

Yes, even tried a power-cycle, but I might have been a bit inpatient when pulling the plug, but that was after it had done 2 softrestarts just after the upgrade.
I too have experienced this once a year or so ago, so I knew what to do …