Preparation for 2.5M2

marcel_erkel · June 18, 2019, 9:08pm

But that IMHO is not a show stopper for 2.5.0.M2 and therefor something for a different topic.

bjoernbrings · June 20, 2019, 9:00pm

So it’s only #674 left on Kai’s list

J-N-K · June 20, 2019, 9:22pm

We should not do M2 with known not-working-at-all problems for bindings. This is at least true for BlueZ (which i still do not fully understand but can be fixed at least temporarily) and Allplay (which is reported to work but not merged).

Kai · June 23, 2019, 5:37pm

I agree. Please provide issue numbers that you think should be put on the list.

J-N-K · June 24, 2019, 4:01pm

Bluetooth/BlueZ: https://github.com/openhab/openhab2-addons/issues/5680 (PR: https://github.com/openhab/openhab2-addons/pull/5706)

Allplay: https://github.com/openhab/openhab2-addons/issues/5643 (PR: https://github.com/openhab/openhab2-addons/pull/5503)

morph166955 · June 24, 2019, 6:22pm

I can not find a specific issue on this on github. My sitemaps are having issues updating on both the web and android app since moving to the nightly builds after M1. Specifically, I use an item to handle visibility to reduce how much is on the screen at once. For example, I may have one that gets set to “TV” or “ROKU” so that only controls for that device in the room are displayed. In the past, when I hit the selector it would change what is on the screen. Now, I am presented with this error in the log file and nothing on the screen updates. If I refresh the page the correct content is shown.

2019-06-24 12:35:18.245 [WARN ] [pse.smarthome.core.items.GenericItem] - failed notifying listener 'org.eclipse.smarthome.io.rest.sitemap.internal.PageChangeListener@5fad6063' about state update of item PrimarySelector: null
java.lang.NullPointerException: null
        at org.eclipse.smarthome.core.items.dto.ItemDTOMapper.fillProperties(ItemDTOMapper.java:152) ~[137:org.openhab.core:2.5.0.201906210301]
        at org.eclipse.smarthome.core.items.dto.ItemDTOMapper.map(ItemDTOMapper.java:138) ~[137:org.openhab.core:2.5.0.201906210301]
        at org.eclipse.smarthome.io.rest.core.item.EnrichedItemDTOMapper.map(EnrichedItemDTOMapper.java:56) ~[?:?]
        at org.eclipse.smarthome.io.rest.sitemap.internal.PageChangeListener.constructSitemapEvents(PageChangeListener.java:242) ~[?:?]
        at org.eclipse.smarthome.io.rest.sitemap.internal.PageChangeListener.constructAndSendEvents(PageChangeListener.java:174) ~[?:?]
        at org.eclipse.smarthome.io.rest.sitemap.internal.PageChangeListener.stateChanged(PageChangeListener.java:188) ~[?:?]
        at org.eclipse.smarthome.core.items.GenericItem$1.run(GenericItem.java:262) [137:org.openhab.core:2.5.0.201906210301]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:?]
        at java.lang.Thread.run(Thread.java:748) [?:?]

cweitkamp · June 24, 2019, 8:46pm

@morph166955 Thank you for reporting the error. It looks like a new one. May I ask you to open an issue in this Git repository. Is it possible to add a minimal example to reproduce it? I will look into it. Thanks in advance.

// Edit: I filed the issue on my own. It was possible to reproduce the NPE. See https://github.com/openhab/openhab-core/issues/897 for more details.

bjoernbrings · June 26, 2019, 10:03pm

As #5706 seems (since today) to be nearly done and #5503 is (hopefully) only waiting for some repo transfer from @Kai.

Does anyone feel able to provide a solution for #674? It is on the blocker list and is without any comment since Apr 10th.
It seems like some (rather small) script could do the deal. Any (migration) script experts around?
(Sorry for not providing a solution but only tracking the progress towards one)

Bruce_Osborne · June 26, 2019, 10:54pm

#930 looks to me like it could be a blocker.
Z-Wave & Zigbee are fairly important.

5iver · June 26, 2019, 10:59pm

If that’s not a blocker, #8 should be. The issue you linked to is preventing #8 from being resolved.

5iver · June 26, 2019, 11:08pm

There is a manual workaround and it would be a small subset of people that would be affected (NGRE, JSON rules). Markus provided an example of how this could be resolved for MapDB. I plan to look into this after migrating/fixing/reenabling the automation itests, if someone hasn’t already gotten to it.

mhilbush · June 27, 2019, 11:14am

@5iver Have you tried the latest zwave snapshot? I’m curious if the removal of the event stuff in PR 1192 might possibly resolve this.

5iver · June 27, 2019, 7:19pm

S1624 and zwave 2.5.0.201906270431… kicked off a heal and sending commands to zwave devices has no effect… same issue.

puzzle-star · June 28, 2019, 1:37am

I opened an issue today (Issue #5770), as it seems the cloud service gets blocked when using the mobile app after PR #5631

The openhab cloud connector addon is not working properly to me since that PR, which removes the increase of maximum httpclient connections to a same destination for the instance used by the addon to connect to the local openhab’s rest API.

The change itself makes sense as since PR #5612 the connector is now using the common shared httpclient, so its parameters should not be changed. But this makes it allow only the “default” 2 maximum connections to the local rest api (which is a single destination), and this blocks the cloud connector.

So, as a summary, the cloud addon does not really work with, at least, the android app, which requests a long rest “event” subscription: one client works (slowly) till you start navigating through the sitemap, and at that moment it blocks and fails. Two clients at the same time block the cloud connector directly.

5iver · June 28, 2019, 2:22am

The reason I made the OP a wiki post was so that people could add/edit the things they felt were holding up the release (hint hint ).

puzzle-star · June 28, 2019, 8:26am

Assuming the OP is somewhere I could list this issue in, I will be happy to do it… as soon as I know where / how to do it…

Maybe the answer is obvious, but I looked into the project you created and I cannot see how to add / edit anything there (or maybe it is no there?)

5iver · June 28, 2019, 8:28am

Click the edit button on the first post of this topic.

puzzle-star · June 28, 2019, 1:27pm

Done! So I assume “OP” means “Original Post” ?

bjoernbrings · June 28, 2019, 4:32pm

This discussion seems to me getting far away from a “Monthly” () release but more in the direction of a stable release. Why not do the monthly release when #5503 is solved.

There will be many more bugs but we need to get the features out to the people to get the bugs found to be able to work towards a stable release …

Kai · June 28, 2019, 8:50pm

No worries @bjoernbrings, the openhab-cloud connector issue is already fixed, so it won’t delay any milestone builds .