Proxy Server for innogy SmartHome Binding

millecker · October 8, 2018, 8:53am

Hi,

I have tried to configure a proxy server by using the EXTRA_JAVA_OPTS in /etc/default/openhab2 as suggested in [1] and [2].

EXTRA_JAVA_OPTS="-Dhttp.proxySet=true -Dhttps.proxyHost=proxy.xxx.org -Dhttps.proxyPort=8080 -Dhttp.proxyHost=proxy.xxx.org -Dhttp.proxyPort=8080 -Dhttp.nonProxyHosts='localhost|127.0.0.1'"

But I think the InnogyWebSocket isn’t picking up these proxy settings:

10:05:45.859 [ERROR] [gysmarthome.internal.InnogyWebSocket] - innogy WebSocket onError() - Connect Timeout
2018-10-08 10:05:46.587 [ERROR] [marthome.handler.InnogyBridgeHandler] - Error starting websocket.
java.util.concurrent.ExecutionException: java.net.SocketTimeoutException: Connect Timeout
        at org.eclipse.jetty.util.FuturePromise.get(FuturePromise.java:123) [87:org.eclipse.jetty.util:9.3.21.v20170918]
        at org.openhab.binding.innogysmarthome.internal.InnogyWebSocket.start(InnogyWebSocket.java:79) [196:org.openhab.binding.innogysmarthome:2.3.0]
        at org.openhab.binding.innogysmarthome.handler.InnogyBridgeHandler$WebSocketRunner.run(InnogyBridgeHandler.java:191) [196:org.openhab.binding.innogysmarthome:2.3.0]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:?]
        at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:?]
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) [?:?]
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) [?:?]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:?]
        at java.lang.Thread.run(Thread.java:748) [?:?]
Caused by: java.net.SocketTimeoutException: Connect Timeout
        at org.eclipse.jetty.io.ManagedSelector$ConnectTimeout.run(ManagedSelector.java:683) ~[?:?]

May it be possible that the proxy has to be explicitly set in the WebSocketClient constructor by using the HttpClient?

github.com

openhab/openhab2-addons/blob/master/addons/binding/org.openhab.binding.innogysmarthome/src/main/java/org/openhab/binding/innogysmarthome/internal/InnogyWebSocket.java#L69


/**
 * Starts the {@link InnogyWebSocket}.
 *
 * @throws Exception
 */
public synchronized void start() throws Exception {
    SslContextFactory sslContextFactory = new SslContextFactory();
    // sslContextFactory.setTrustAll(true); // The magic


    if (client == null || client.isStopped()) {
        client = new WebSocketClient(sslContextFactory);
        client.setMaxIdleTimeout(this.maxIdleTimeout);
        client.start();
    }


    if (session != null) {
        session.close();
    }


    logger.debug("Connecting to innogy WebSocket...");
    session = client.connect(this, webSocketURI).get();

This might be a possible solution:

SslContextFactory sslContextFactory = new SslContextFactory();
// sslContextFactory.setTrustAll(true); // The magic

HttpClient httpClient = new HttpClient(sslContextFactory);

// Optional add proxy to httpClient
if (StringUtils.isNotEmpty(config.getProxyHost()) && StringUtils.isNotEmpty(config.getProxyPort())) {
	LOGGER.debug("Use Proxy for Websocket: " + config.getProxyHost() + ":" + config.getProxyPort());
	ProxyConfiguration proxyConfig = httpClient.getProxyConfiguration();
	HttpProxy proxy = new HttpProxy(config.getProxyHost(), Integer.parseInt(config.getProxyPort()));
	proxyConfig.getProxies().add(proxy);
}
// Start HttpClient
httpClient.start();

// Create WebSocketClient
client = new WebSocketClient(httpClient);

Or is there another fix to get the innogy SmartHome binding working with a proxy server?

Thanks!

[1] Proxy Server for HTTP Binding
[2] Set up HTTP Bindings when openHAB runs behind a HTTP proxy