Rules triggers all the time without end

[Wurzelseppi (Julian)]

Hi,

I have a light timer rule which should add a timer to every light switch and turns it off after a defined time period
Code is ihere `rule “LIGHT-TIMER”
when
Item group___powersaving_CUSTOMGROUP received update
then

val lightValue = illumination_sensor_aussendachmastlicht.state

try{

var loopBreak = 0
while(!lock.tryLock())
{
	Thread::sleep(2000)
	logInfo("Powersaving", "Waiting for lock")
	loopBreak++
	if(loopBreak > 10)
	{
		logInfo("Powersaving", "couldn´t get lock - exiting")
		return
	}
}
val mostRecent = group___powersaving_CUSTOMGROUP?.allMembers.sortBy[lastUpdate].last
logInfo("Powersaving", "Most recent"+mostRecent.name)
logInfo("Powersaving", "lightValue: "+lightValue)
//This is the value for night time (see time settings below)
var timeValue = 60
if(lightValue > 15000)
{
	timeValue = 10
}

lightTimers.apply(mostRecent, timers, timeValue)			

}
finally{
lock.unlock();
}
end`

and the lambda is`val org.eclipse.xtext.xbase.lib.Functions$Function3 lightTimers = [
SwitchItem relayItem,
java.util.Map<String, Timer> timers,
int timeout |

logInfo("Powersaving", "PRINTING ALL TIMERS *****************")
timers.forEach[
	k, v|
	logInfo("Powersaving", "TIMER ITEM :"+k)
]
logInfo("Powersaving", "PRINTING ALL TIMERS END *****************")
logInfo("Powersaving", "state of " + relayItem)

val tUid = now.millis

if (relayItem.state == ON) {			
	// now create a new timer for switching off
	if(timers.get(relayItem.name) == null){
		logInfo("Powersaving", "***************** CREATING Timer for '"+relayItem.name+"' with timeout '"+timeout+"' uid="+tUid)
		timers.put(relayItem.name, createTimer(now.plusMinutes(timeout)) [|
		logInfo("Powersaving", "INNER-TIMER - ENTERING LAMBDA with item ("+relayItem.name+") with timeout ("+timeout+") uid="+tUid+"***********************************************")
		// switch it off afterwards, if it is not already off
		if (relayItem.state == ON){
			logInfo("Powersaving", "INNER-TIMER - Switching "+relayItem.name+"' OFF. uid="+tUid+"***********************************************")
			relayItem.sendCommand(OFF)
			logInfo("Powersaving", "INNER-TIMER - Removing "+relayItem.name+"' from timers. uid="+tUid+"***********************************************")
			timers.remove(relayItem.name)
		}
		logInfo("Powersaving", "INNER-TIMER - LEAVING LAMBDA with item ("+relayItem.name+") with timeout ("+timeout+") uid="+tUid+"***********************************************")
		])				
	}
}
else{
	if(timers.containsKey(relayItem.name))
		logInfo("Powersaving", "Removing "+relayItem.name+"' from timers 2")
		timers.remove(relayItem.name)
}

]`

The problem is, that my logs are full of these logs now, because the rules is triggerd all the time, not only when a light in group___powersaving_CUSTOMGROUP gets an update …

[rossko57]

This might offer some insight into Group based rules

Design Pattern: Working with Groups in Rules

Edit: Updates for OH 4, inclusion of JS Scripting and Blockly examples, removed the doors example as it’s superfluous. Please see Design Pattern: What is a Design Pattern and How Do I Use Them for how to read and use DPs. Problem Statement One powerful way to consolidate code in rules is to use array/list manipulation operations on the members of a Group. For example, filter down to just those members that are ON, get a list of the labels of those Items that are NULL, etc. Concept [image] T…

Note particularly

note: Rules triggered by updates to a Group Item will generate multiple triggers for each single change to an Item.

Further, we don’t know what is in your group, and so cannot see if your rule functions trigger a further group update, to cause a loop.

[opus (Jürgen Baginski)]

Your initial rule triggers for “received update”, that would be ANY update in the group, switching from OFF to ON and vice versa. Your lambda expression is called all the time, even if it doesn’the start a timer, hence your log entries.