[SOLVED] Heatit z-trm2 anyone tried it in OH2?

[chris (Chris Jackson)]

@Alexus1211

Could it be related to the rule I am using, because from PaperUI everything works fine:

Sorry - I didn’t realise that it works in PaperUI, and doesn’t work if you use a rule. To me, I would suggest that this is not a binding issue.

I would suggest to check the logs for both types to see what the difference is. Please provide the logs so we can see what is happening.

[Alexus1211 (Alex)]

@Alexus1211

Could it be related to the rule I am using, because from PaperUI everything works fine:

Sorry my msitake. It does not. But in PaperUI I can see that the UI does not pickup the correct type for setpoints (QuantityType) either. For temperature everything looks fine. Check this screenshot:

As you can see, both mapped and defined items for temperature are shown correctly in PaperUI for the temperature channel:

<channel id="sensor_temperature" typeId="sensor_temperature">
        <label>Sensor (temperature)</label>
        <properties>
          <property name="binding:*:QuantityType">COMMAND_CLASS_SENSOR_MULTILEVEL;type=TEMPERATURE</property>
        </properties>
</channel>

But for the setpoint channel (the second one), only the defined one in the items file seems to be displayed correctly. The mapped item from the channel definition did not pick up the correct type, so it is shown without any units, although in the channel definition the QunatityType has been set:

<channel id="thermostat_setpoint_heating" typeId="thermostat_setpoint">
        <label>Setpoint (heating)</label>
        <properties>
          <property name="binding:*:QuantityType">COMMAND_CLASS_THERMOSTAT_SETPOINT;type=HEATING</property>
        </properties>
 </channel>

Somehow I think for the typeId="thermostat_setpoint" the QunatityType defintion is not being matched in the OH2 core.

Maybe @Kai can support here. Thanks

[chris (Chris Jackson)]

@Alexus1211

Somehow I think for the typeId="thermostat_setpoint" the QunatityType defintion is not being matched in the OH2 core.

What do you mean?

The binding is receiving a QuantityType - correct?

Sorry - I’m not really sure I understand your configuration completely. Also, what version of the binding are you now using? Are you still using your version or the supplied version? I’m not sure it will make any difference, but I would like to understand.

@Alexus1211

The mapped item from the channel definition did not pick up the correct type, so it is shown without any units, although in the channel definition the QunatityType has been set:

Please provide a log as requested. The only way I can see in the software that it would not return a QuantityType is if there is no scale provided -:

        switch (setpointEvent.getScale()) {
            case 0:
                return new QuantityType<>(value, SIUnits.CELSIUS);
            case 1:
                return new QuantityType<>(value, ImperialUnits.FAHRENHEIT);
            default:
                logger.debug("NODE {}: Unknown temperature scale {}", event.getNodeId(), setpointEvent.getScale());
                break;
        }

As you see, there would also be a debug message reported.

[Alexus1211 (Alex)]

@chris

for the display issue in PaperUI this has been solved by modifiying the channels.xml and rebuilding the binding like this:

<!-- Heating Setpoint Channel -->
    <channel-type id="thermostat_setpoint">
        <item-type>Number:Temperature</item-type>
        <label>Heating Setpoint</label>
        <description>Sets the thermostat setpoint</description>
        <category>Temperature</category>
        <state readOnly="false" pattern="%.1f %unit%" />
        <config-description>
            <parameter name="config_scale" type="text">
                <label>Scale</label>
                <description>Select the scale to use for setpoints.</description>
                <default>0</default>
                <options>
                    <option value="0">Celsius</option>
                    <option value="1">Fahrenheit</option>
                </options>
            </parameter>
        </config-description>
    </channel-type>

so now it is showing correctly as it should:

As for the original issue, the problem is still occurring. attached a complete log for this. It occurs with nodes 5,6,7,8,11 and 13.

Logs

Could you please send me link to your latest dev binding so I can test it tonight? Thanks

[chris (Chris Jackson)]

@Alexus1211

for the display issue in PaperUI this has been solved by modifiying the channels.xml and rebuilding the binding like this:

Is it just the state with the %unit% you added or was there something else ? I guess this could also be added in your items file? I forget why I didn’t add this when I updated the channels - there was a reason at the time, but I forget what it was now .

@Alexus1211

Could you please send me link to your latest dev binding so I can test it tonight?

It is always available on the first post of the dev binding thread.

OH2 Z-Wave refactoring and testing... and SECURITY

The latest version of the development binding dated 8th Sep 2018 is here. Toward the end of last year I spent some time doing some initial refactoring of the ZWave binding in OH2. This focussed on rewriting the way transactions work as this is an enabler for other areas of the code. At the same time I also restructured the different layers of the binding to make things cleaner, and done some changes to support a system of autocoding the command classes directly from the Z-Wave standard which s…

[Alexus1211 (Alex)]

@chris

@chris

Is it just the state with the %unit% you added or was there something else ? I guess this could also be added in your items file? I forget why I didn’t add this when I updated the channels - there was a reason at the time, but I forget what it was now .

Yes only this line:

I guess I found something in the code why the issue occurring. I am building it at the moment to see if it works.

[chris (Chris Jackson)]

@Alexus1211

I guess I found something in the code why the issue occurring. I am building it at the moment to see if it works.

Strange - this was updated quite a while ago I thought .

[Alexus1211 (Alex)]

@chris
just tested the change. It is throwing an exception now.

2018-07-24 20:20:56.234 [ome.event.ItemCommandEvent] - Item 'spHeatRoomSensor2' received command 12 °C

==> /var/log/openhab2/openhab.log <==

2018-07-24 20:20:56.247 [ERROR] [nal.common.AbstractInvocationHandler] - An error occurred while calling method 'ThingHandler.handleCommand()' on 'org.openhab.binding.zwave.handler.ZWaveThingHandler@16dfc00': org.eclipse.smarthome.core.library.types.QuantityType cannot be cast to org.eclipse.smarthome.core.library.types.DecimalType

java.lang.ClassCastException: org.eclipse.smarthome.core.library.types.QuantityType cannot be cast to org.eclipse.smarthome.core.library.types.DecimalType

	at org.openhab.binding.zwave.internal.converter.ZWaveThermostatSetpointConverter.receiveCommand(ZWaveThermostatSetpointConverter.java:133) [239:org.openhab.binding.zwave:2.4.0.201807241749]

	at org.openhab.binding.zwave.handler.ZWaveThingHandler.handleCommand(ZWaveThingHandler.java:1078) [239:org.openhab.binding.zwave:2.4.0.201807241749]

	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]

	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:?]

	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]

	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:?]

	at org.eclipse.smarthome.core.internal.common.AbstractInvocationHandler.invokeDirect(AbstractInvocationHandler.java:153) [94:org.eclipse.smarthome.core:0.10.0.201807081340]

	at org.eclipse.smarthome.core.internal.common.InvocationHandlerSync.invoke(InvocationHandlerSync.java:59) [94:org.eclipse.smarthome.core:0.10.0.201807081340]

	at com.sun.proxy.$Proxy182.handleCommand(Unknown Source) [239:org.openhab.binding.zwave:2.4.0.201807241749]

	at org.eclipse.smarthome.core.thing.internal.profiles.ProfileCallbackImpl.handleCommand(ProfileCallbackImpl.java:75) [101:org.eclipse.smarthome.core.thing:0.10.0.201807081340]

	at org.eclipse.smarthome.core.thing.internal.profiles.SystemDefaultProfile.onCommandFromItem(SystemDefaultProfile.java:49) [101:org.eclipse.smarthome.core.thing:0.10.0.201807081340]

	at sun.reflect.GeneratedMethodAccessor81.invoke(Unknown Source) ~[?:?]

	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]

	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:?]

	at org.eclipse.smarthome.core.internal.common.AbstractInvocationHandler.invokeDirect(AbstractInvocationHandler.java:153) [94:org.eclipse.smarthome.core:0.10.0.201807081340]

	at org.eclipse.smarthome.core.internal.common.Invocation.call(Invocation.java:53) [94:org.eclipse.smarthome.core:0.10.0.201807081340]

	at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:?]

	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:?]

	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:?]

	at java.lang.Thread.run(Thread.java:748) [?:?] 

I will test your binding tomorrow early and give you feedback.
Cheers

[Alexus1211 (Alex)]

@chris: I believe it is solved now with this simple change

cheers

[chris (Chris Jackson)]

Ok, I’ll check this to see if how this is different to what’s in the binding at the moment. From a quick look, it looks similar, but I’ll check when I get a chance.

Thanks
Chris

[chris (Chris Jackson)]

I checcked the current binding and I think it’s pretty similar -:

        BigDecimal value;
        if (command instanceof QuantityType) {
            QuantityType<?> quantity = (QuantityType<?>) command;
            if (quantity.getUnit() == SIUnits.CELSIUS) {
                scale = 0;
            } else if (quantity.getUnit() == ImperialUnits.FAHRENHEIT) {
                scale = 1;
            }
            value = quantity.toBigDecimal();
        } else if (command instanceof DecimalType) {
            value = ((DecimalType) command).toBigDecimal();
        } else {
            logger.debug("NODE {}: Thermostat command received with unsupported type {}", node.getNodeId(),
                    command.getClass().getSimpleName());

            return null;
        }

Do you want to try this code in your version, or try the latest development version to see if it is working?

[OMR (Ole Morten Rønning)]

Online User Manual now available:

manual_heatit_z-trm2_eng.pdf

There they boast a 2.9 firmware. My device has 2.6.
@chris what is the best Firmware upgrade route do you think? Any plans to support OTA in OH2?

[sihui]

@OMR

Any plans to support OTA in OH2?

Recommendation for z-wave actuators that provide firmware updates (without propriety server)

The big problem at the moment is that currently no manufacturers are willing to supply the OTA files as stand-alone files. Aeon provide stand-along software that includes the binaries inside, but Fibaro will only supply firmware if you use their (very expensive!) hub. I’ve had discussions with both these manufacturers, and also Qubino - Qubino may be willing to provide firmware, so I’m hopeful that one day all manufacturers will supply these files, and once one or two do, I will look to impleme…

[OMR (Ole Morten Rønning)]

IC.
I have also contacted the manufacturer for advice.
Will report back when they reply.

[chris (Chris Jackson)]

@OMR

Any plans to support OTA in OH2?

The situation is pretty much as the post @sihui linked to. There are currently no known manufacturers who supply the updates - once a few start to release the binary files, then I’m happy to look at OTA in the binding (I’ve already implemented it in ZigBee where suppliers are more open to providing the binaries).

[OMR (Ole Morten Rønning)]

Jury is still out regarding the firmware file.
In the mean time, my local z-wave pusher had a 18% discount on the z-trm2 so I bought a few more

Two of my thermostats are mounted as Power regulators (1-10 setting ON/OFF duty), mounted in another room.
The z-trm2 also supports this mode, but only as parameter 12 (even though doc states it does not)

Since I’m planning on monitoring the temperature using Aeon multisensor6 in the actual rooms I will need to set this parameter from a rule.

@chris Is it possible to make parameter 12 available via a channel, or is it possible to send new parameter values from a rule?

[chris (Chris Jackson)]

@OMR

@chris Is it possible to make parameter 12 available via a channel

Yes, I will add this.

@OMR

is it possible to send new parameter values from a rule?

Unfortunately ESH doesn’t provide this feature (at the moment at least).

[OMR (Ole Morten Rønning)]

Nice.
While you’re at it:

Will make it possible to turn off display in bedroom at night

[chris (Chris Jackson)]

@OMR

While you’re at it:

Done…

I’ll do a binding update tonight or tomorrow…

[OMR (Ole Morten Rønning)]

Did the new channels make it to?: