It is not needed, but if I’ve tested for its existence in a specific path, why not fully qualify it? Both apt and yum/dnf based systems will have openhab-cli in /usr/bin/, so the else in your if/then would be unreachable, and will error for manual installations. That’s why I did this…
if [[ -f "/usr/bin/openhab-cli" ]]; then
/usr/bin/openhab-cli console ${KARAF_FUNCTION} --
else
../runtime/bin/client ${KARAF_FUNCTION} --
fi
I was noticing that too and will look into it later. However, I don’t think manual installations are necessary in most cases, so I plan to make a version of the script that will just upgrade the binding in place, using this method…
bundle:update org.openhab.binding.zwave https://openhab.jfrog.io/openhab/online-repo-snapshot/2.5/org/openhab/binding/org.openhab.binding.zwave/2.5.0-SNAPSHOT/org.openhab.binding.zwave-2.5.0-SNAPSHOT.jar
For zwave, there’s not much need for a script, but it makes it convenient. For zigbee, you’d need to enter it four times, so much more convenient with a script. And no jar files or addons.cfg to worry about! Of course, the best solution is to add the ability to individually select which release/repository a binding is pulled from, and a UI for triggering the update.