How to make a method / procedure from a rule

[knaxman (Ralph Burgstahler)]

Hi,

I have 15 Rollershutters and would like to use one coded rule for all the rollershutter items.

here my rule

rule "Item EG_WO_Rolladen_Links"
when Item EG_WO_Rolladen_Links_Proxy received command
then    
        if (receivedCommand == UP || receivedCommand == STOP || receivedCommand == DOWN) {
            if (receivedCommand == UP) {
            EG_WO_Rolladen_Links_Set.sendCommand(99)
            }
            if (receivedCommand == STOP) {
            EG_WO_Rolladen_Links_Stop.sendCommand(ON)
            }
            if (receivedCommand == DOWN) {
            EG_WO_Rolladen_Links_Set.sendCommand(0)
            }
        }    
            else { //bei allen anderen Werten Wert direkt in Actuator schreiben
            EG_WO_Rolladen_Links_Set.sendCommand(receivedCommand)
             
            }

end

rule "Item EG_WO_Rolladen_Links -postupdate"
when Item EG_WO_Rolladen_Links_Level changed
then EG_WO_Rolladen_Links_Proxy.postUpdate(EG_WO_Rolladen_Links_Level.state)
end

I want the code one method / function and call the function just with “EG_WO_Rolladen_Links” .
Thought I can find an example how to do it but I may search for the wron g keywords.

Does someone has an example where I can start with.

[Bruce_Osborne]

Perhaps using Jython and the new rules engine?

[rossko57]

Sure, there is lots of published advice, but it is hard to find without the right keyword

Design Pattern: Working with Groups in Rules

Please see Design Pattern: What is a Design Pattern and How Do I Use Them for how to read and use DPs. Problem Statement Often one finds a number of Rules that are very similar and that all work on similar Items resulting in a lot of duplicated code. One way to solve this problem is through the use of Groups. Concept [image] This DP is not a standard DP in that it provides a single concrete template to follow to solve a specific problem. Instead this DP is more of a grand exploration of some …

Design Pattern: Associated Items

Please see Design Pattern: What is a Design Pattern and How Do I Use Them for how to read and use DPs. Problem Statement Often one will have a number of separate Items which are all related to each other in some way. For example, one might have a Contact on a door and a DateTime to represent when the last time the door was opened. This is easy enough to keep track of if there are only one or two such Items, but if one has a lot of similar Items or is using a lot of generically coded rules where…

[ljsquare (Laurens Jan Merkx)]

@knaxman

I want the code one method / function and call the function just with “EG_WO_Rolladen_Links” .

It is certainly possible. But at my iPad I can’t give you a quick example.
I’ll try to give you an example tomorrow

[5iver (Scott Rushworth)]

@knaxman

I want the code one method / function and call the function just with “EG_WO_Rolladen_Links” .

While this would be very simple to do with scripted automation, do you really need a function or just a single rule? If you put your proxy Items into a group named PROXY_ITEMS…

rule "Item EG_WO_Rolladen_Links"
when 
    Member of PROXY_ITEMS received command
then    
    if (receivedCommand == UP || receivedCommand == STOP || receivedCommand == DOWN) {
        if (receivedCommand == UP) {
            sendCommand(triggeringItem.name.replace("_Proxy", "_Set"), "99")
        }
        if (receivedCommand == STOP) {
            sendCommand(triggeringItem.name.replace("_Proxy", "_Stop"), "ON")
        }
        if (receivedCommand == DOWN) {
            sendCommand(triggeringItem.name.replace("_Proxy", "_Set"), "0")
        }
    } else { //bei allen anderen Werten Wert direkt in Actuator schreiben
        sendCommand(triggeringItem.name.replace("_Proxy", "_Set"), receivedCommand.toString)
    }
end

[Edited to fix a typo]

[ljsquare (Laurens Jan Merkx)]

@ljsquare

I’ll try to give you an example tomorrow

here is an example:

val rollerShutters_Left = [RollershutterItem item,UpDownType command |
		switch command.toString {
		case "UP"	: item.sendCommand(99)
		case "DOWN"	: item.sendCommand(0)
		default : item.sendCommand(command)
	}
 ]
rule "Item EG_WO_Rolladen_Links -postupdate"
when 
	Item EG_WO_Rolladen_Links_Level changed
then 
	rollerShutters_Left.apply(EG_WO_Rolladen_Links_Set, EG_WO_Rolladen_Links_Level.state as UpDownType)
end

But I’m not sure what kind of items or groups you use. I noticed that voor STOP you use a different item. That is not possible with a simple procedure as I’ve given you.
Can you please share your items?

[Udo_Hartmann]

Use Groups for each type of Items:

Group gRollProxy //(all _Proxy Items)
Group gRollSet   //(all _Set   Items)
Group gRollStop  //(all _Stop  Items)
Group gRollLevel //(all _Level Items)

Now it’s easy to build two Rules

rule "Rollladen Proxy"
when
    Member of gRollProxy received command // A member of the Group gRollProxy received a command
then
    val String strItem = triggeringItem.name.replace("_Proxy", "")  // get first part of name
    switch(receivedCommand){
        case UP   :  gRollSet.members.filter[i|i.name.contains(strItem)].head.sendCommand(99)
        case DOWN :  gRollSet.members.filter[i|i.name.contains(strItem)].head.sendCommand(0)
        case STOP : gRollStop.members.filter[i|i.name.contains(strItem)].head.sendCommand(ON)
        default   :  gRollSet.members.filter[i|i.name.contains(strItem)].head.sendCommand(receivedCommand)
    }
end

rule "gRollLevel postUpdate"
when 
    Member of gRollLevel changed
then
    val String strItem = triggeringItem.name.replace("_Level", "")
    gRollProxy.members.filter[i|i.name.contains(strItem)].head.postUpdate(triggeringItem.state.toString)
end